Chore (Core App): Remove legacy bootstrap stylesheets #4385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuarrrr
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX and
Flyingliuhub
as code owners
Codecov Report
@@ Coverage Diff @@
## main #4385 +/- ##
==========================================
+ Coverage 66.74% 66.77% +0.03%
==========================================
Files 3284 3284
Lines 63095 63095
Branches 10049 10049
==========================================
+ Hits 42110 42134 +24
+ Misses 18488 18487 -1
+ Partials 2497 2474 -23
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joshuarrrr
changed the base branch from
feature/oui-re-theme
to
feature/deangular
abbyhu2000
force-pushed
the
feature/deangular
branch
from
f14c199
to
e6b9ab2
Compare
joshuarrrr
force-pushed
the
chore/remove-legacy-stylesheets
branch
from
dd456c9
to
db0834b
Compare
Signed-off-by: Josh Romero <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
joshuarrrr
force-pushed
the
chore/remove-legacy-stylesheets
branch
from
6cad7f6
to
e66089b
Compare
|
Closing as this will take more work to do at some point |
|
@joshuarrrr Due to an extended period without updates, we're going to close this issue for now. We appreciate your contribution and understand that priorities and availability can change. Please feel free to reopen this issue when you have the opportunity to revisit it. Thank you for your understanding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will not target
mainuntil after much more thorough testing. But for now, I want to remove these legacy stylesheets from the feature branch so we can start discovering the (expectedly rare) cases where they're actually having any effect.Issues Resolved
Fixes #4305
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr